Do you remember Chi pants, in the 80s? (I think) That was their big deal. They were very comfortable. Now I have a couple of pairs of pants from LL Bean that have the same kind of construction.

I hadn't heard "diamond crotch" before, always seen it referred to as a "gusset" (which can exist in armpits or anywhere else an extra piece of fabric can be helpful.)